feat: 'data retention is over' message across sandbox tabs#474
Draft
huv1k wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bbfeb67 to
5deb9df
Compare
Render a single shared message on a sandbox's monitoring/events/logs tabs once that data has aged past its 7-day TTL, replacing empty views and the old client-side logs retention check. - models: add retentionExpired to the sandbox details model + mappers - common/data-retention-expired.tsx: shared message component - monitoring/events/logs views: render it when retentionExpired is set - details resolver: also flag paused sandboxes paused longer than 7d (killed sandboxes use the backend flag; running/resumed sandboxes clear it) - spec sync + regenerated dashboard-api contract types
1baf9d3 to
01f7e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shows a single, consistent "Data retention is over" message on a sandbox's monitoring / events / logs tabs once that data has aged past its 7-day TTL — replacing empty views and the old ad-hoc, client-side logs check.
Changes
models.ts: add `retentionExpired` to the sandbox details model; map it from the backend record (killed) and default `false` for live infra detail.common/data-retention-expired.tsx: new shared message component.sandbox.ts(detailsresolver): also flag paused sandboxes whose last pause is older than 7 days (the backend already exposes the pause time via `endAt`/lifecycle `pausedAt`). Resumed/running sandboxes clear the flag automatically; killed sandboxes use the backend flag.Matrix
Companion